Skip to content

avoid fmt.Sprintf and string alloc for time.Sql #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2024
Merged

avoid fmt.Sprintf and string alloc for time.Sql #2782

merged 3 commits into from
Dec 6, 2024

Conversation

@max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Dec 5, 2024 •
edited
Loading

perf here dolthub/dolt#8640

@max-hoffman max-hoffman mentioned this pull request Dec 5, 2024
Closed
@max-hoffman max-hoffman requested a review from jycor December 6, 2024 00:45
jycor
jycor approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@max-hoffman max-hoffman merged commit c4c1d5f into main Dec 6, 2024
8 checks passed
@max-hoffman max-hoffman deleted the max/time-bytes branch December 6, 2024 18:41
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jycor jycor jycor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@max-hoffman @jycor